PHP 8.3: Warning about passing argument 1 of 'zval_ptr_dtor' from incompatible pointer type

[kdambekalns]

Here is what the compilation says:

/opt/php/src/ext/yaml/parse.c: In function 'handle_sequence':
/opt/php/src/ext/yaml/parse.c:534:18: warning: passing argument 1 of 'zval_ptr_dtor' from incompatible pointer type [-Wincompatible-pointer-types]
  534 |    zval_ptr_dtor(&retval);
      |                  ^~~~~~~
      |                  |
      |                  zval ** {aka struct _zval_struct **}
In file included from /opt/php/include/php/Zend/zend.h:36,
                 from /opt/php/include/php/main/php.h:31,
                 from /opt/php/src/ext/yaml/php_yaml.h:46,
                 from /opt/php/src/ext/yaml/parse.c:36:
/opt/php/include/php/Zend/zend_variables.h:79:35: note: expected 'zval *' {aka 'struct _zval_struct *'} but argument is of type 'zval **' {aka 'struct _zval_struct **'}
   79 | ZEND_API void zval_ptr_dtor(zval *zval_ptr);
      |                             ~~~~~~^~~~~~~~

[bd808]

That warning was fixed by #74 (e7bffc0). This and a few other small fixes have not yet been released but are available from the php7 default branch.

[kdambekalns]

Thanks! I would not have checked the php7 branch for this… 🙈 Great to hear – and "small fixes" sounds like nothing that would block a release around the time PHP 8.3 is released as stable. 🎉