Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML 1.2 #64

Open
downsider opened this issue Feb 4, 2022 · 3 comments
Open

YAML 1.2 #64

downsider opened this issue Feb 4, 2022 · 3 comments
Labels

Comments

@downsider
Copy link

Hi

I'm looking into using this yaml extension to improve performance on yaml parsing for an application I'm working on, but have a question.

My current parser, the Symfony yaml library, supports yaml 1.2, however this extension states explicitly that it only supports 1.1. Is there a reason for this?

Also, what would it take to add support for yaml 1.2?

@bd808
Copy link
Collaborator

bd808 commented Feb 27, 2022

It would require at least yaml/libyaml#20. I'm not sure what if any changes would be needed in how this library wraps libyaml or interfaces with PHP internals.

Is there a specific YAML 1.2 feature that you know that you depend on?

@downsider
Copy link
Author

Thank you for your reply

It's more that we have a large number of yaml documents that we use and we don't know if they are all 100% compatible with yaml 1.1

For this to be a drop-in replacement for symfony/yaml we would need that compatibility, otherwise we have a much bigger project to review every document to make sure we don't get regression bugs.

@bd808 bd808 added the question label Mar 12, 2023
@andypost
Copy link
Contributor

andypost commented Dec 26, 2023

There's reference to https://github.com/pantoniou/libfyaml which implementing 1.2 already, according to yaml/libyaml#20 (comment)

EDIT Maybe extension could be build using this library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants