Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zookeeper-0.7.2 cannot build with php 7.3 #42

Open
patrickzeng12 opened this issue Nov 20, 2020 · 2 comments
Open

zookeeper-0.7.2 cannot build with php 7.3 #42

patrickzeng12 opened this issue Nov 20, 2020 · 2 comments

Comments

@patrickzeng12
Copy link

I compiled the zookeeper C binding and ran the sudo pecl install zookeeper-0.7.2 --with-libzookeeper-dir=/usr/local to install php zookeeper extension. But I ran into the following error:
running: make /bin/sh /private/tmp/pear/temp/pear-build-rootQPOaV4/zookeeper-0.7.2/libtool --mode=compile cc -I/usr/local/Cellar/php@7.3/7.3.24/include/php -I. -I/private/tmp/pear/temp/zookeeper -DPHP_ATOM_INC -I/private/tmp/pear/temp/pear-build-rootQPOaV4/zookeeper-0.7.2/include -I/private/tmp/pear/temp/pear-build-rootQPOaV4/zookeeper-0.7.2/main -I/private/tmp/pear/temp/zookeeper -I/usr/local/Cellar/php@7.3/7.3.24/include/php -I/usr/local/Cellar/php@7.3/7.3.24/include/php/main -I/usr/local/Cellar/php@7.3/7.3.24/include/php/TSRM -I/usr/local/Cellar/php@7.3/7.3.24/include/php/Zend -I/usr/local/Cellar/php@7.3/7.3.24/include/php/ext -I/usr/local/Cellar/php@7.3/7.3.24/include/php/ext/date/lib -I/usr/local/include/zookeeper -DHAVE_CONFIG_H -g -O2 -c /private/tmp/pear/temp/zookeeper/php_zookeeper.c -o php_zookeeper.lo mkdir .libs cc -I/usr/local/Cellar/php@7.3/7.3.24/include/php -I. -I/private/tmp/pear/temp/zookeeper -DPHP_ATOM_INC -I/private/tmp/pear/temp/pear-build-rootQPOaV4/zookeeper-0.7.2/include -I/private/tmp/pear/temp/pear-build-rootQPOaV4/zookeeper-0.7.2/main -I/private/tmp/pear/temp/zookeeper -I/usr/local/Cellar/php@7.3/7.3.24/include/php -I/usr/local/Cellar/php@7.3/7.3.24/include/php/main -I/usr/local/Cellar/php@7.3/7.3.24/include/php/TSRM -I/usr/local/Cellar/php@7.3/7.3.24/include/php/Zend -I/usr/local/Cellar/php@7.3/7.3.24/include/php/ext -I/usr/local/Cellar/php@7.3/7.3.24/include/php/ext/date/lib -I/usr/local/include/zookeeper -DHAVE_CONFIG_H -g -O2 -c /private/tmp/pear/temp/zookeeper/php_zookeeper.c -fno-common -DPIC -o .libs/php_zookeeper.o /private/tmp/pear/temp/zookeeper/php_zookeeper.c:1540:44: error: use of undeclared identifier 'ZOO_MAJOR_VERSION' snprintf(buf, sizeof(buf), "%ld.%ld.%ld", ZOO_MAJOR_VERSION, ZOO_MINOR_VERSION, ZOO_PATCH_VERSION); ^ /private/tmp/pear/temp/zookeeper/php_zookeeper.c:1540:63: error: use of undeclared identifier 'ZOO_MINOR_VERSION' snprintf(buf, sizeof(buf), "%ld.%ld.%ld", ZOO_MAJOR_VERSION, ZOO_MINOR_VERSION, ZOO_PATCH_VERSION); ^ /private/tmp/pear/temp/zookeeper/php_zookeeper.c:1540:82: error: use of undeclared identifier 'ZOO_PATCH_VERSION' snprintf(buf, sizeof(buf), "%ld.%ld.%ld", ZOO_MAJOR_VERSION, ZOO_MINOR_VERSION, ZOO_PATCH_VERSION); ^ 3 errors generated. make: *** [php_zookeeper.lo] Error 1 ERROR: 'make' failed

@camporter
Copy link

camporter commented Nov 23, 2020

Possibly due to apache/zookeeper#1162 which will require checking for ZOO_VERSION if defined, otherwise the individual versions, similar to the perl bindings in apache/zookeeper@bcd6d3b

@patrickzeng12
Copy link
Author

@camporter thanks for the reference. I found that version 3.5.8 still has the old ZOO_***_VERSION constants so I'm using that version to get by for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants