Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: recommend a two step migration #57

Open
sagikazarmark opened this issue Dec 30, 2015 · 5 comments
Open

Migration: recommend a two step migration #57

sagikazarmark opened this issue Dec 30, 2015 · 5 comments
Assignees

Comments

@sagikazarmark
Copy link
Member

I think most people fear from breaking BC. I absolutely agree with them, that's why I think we should recommend them a two step migration.

  1. Use HTTPlug internally, don't change the public API. In most cases this is a simple constructor injection of an HTTP Client. We could just wrap this around one of our adapter and use HTTPlug API internally.
  2. Once the author is confident that the package is stable and HTTPlug works, he can change the public API as well, fully decoupling the package from the actual implementation.
@dbu
Copy link
Contributor

dbu commented Dec 31, 2015 via email

@sagikazarmark
Copy link
Member Author

Yes. The idea came from the fact that people might not get the idea of httplug, so they might not want to use it for various reasons. One of them can be breaking BC, which is clearly not necessary with this two-step migration.

@ddeboer
Copy link
Contributor

ddeboer commented Jan 3, 2016

@sagikazarmark Can you open a PR for this?

@sagikazarmark
Copy link
Member Author

Will do.

@ddeboer
Copy link
Contributor

ddeboer commented Jan 3, 2016

👍

_____________________________

From: Márk Sági-Kazár notifications@github.com
Sent: zondag, januari 3, 2016 9:05 PM
Subject: Re: [documentation] Migration: recommend a two step migration (#57)
To: php-http/documentation documentation@noreply.github.com
Cc: David de Boer david@ddeboer.nl

Will do.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants