Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against large capacities when allocating #33

Open
rtheunissen opened this issue Aug 3, 2016 · 2 comments
Open

Guard against large capacities when allocating #33

rtheunissen opened this issue Aug 3, 2016 · 2 comments
Assignees
@rtheunissen
Labels
Improvement Internals

Comments

@rtheunissen
Copy link
Member

We currently allow allocation via allocate(int $capacity), but we don't check for overflow or have a maximum capacity. @nikic also mentioned that we should be using the safe_* variants when multiplying sizeof by a variable capacity.
@rtheunissen rtheunissen added this to the 2.0.0 milestone Aug 30, 2016
@rtheunissen rtheunissen self-assigned this Aug 30, 2016
@rtheunissen rtheunissen removed this from the 2.0.0 milestone Jul 19, 2017
@rtheunissen
Copy link
Member Author

2.0 won't support allocate so this is now a 1.* issue.

@rtheunissen
Copy link
Member Author

I think we should just remove explicit allocation entirely, in both 1.x and 2.0

@rtheunissen rtheunissen reopened this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtheunissen rtheunissen

Labels
Improvement Internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rtheunissen