Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize explicit PI ref over PHOTON_INHERIT #164

Open
noble-ux opened this issue Aug 27, 2020 · 2 comments
Open

Prioritize explicit PI ref over PHOTON_INHERIT #164

noble-ux opened this issue Aug 27, 2020 · 2 comments
Labels
enhancement An improvement to an already existing feature

Comments

@noble-ux
Copy link
Member

Ideal Behaviour

Vehicles with the following code should pull a predefined PI config if available:
HasPhoton = true, Photon = "PHOTON_INHERIT"

Actual Behaviour

Currently this script will prevent a photon config from using a predefined PI config. Currently this code actually needs to be removed in order to utilize the PI config without referencing it directly as seen below:
HasPhoton = true, Photon = "sgm_fpiu20"

@noble-ux noble-ux added the bug Something's broken that shouldn't be. label Aug 27, 2020
@JoshPiper
Copy link
Member

Not a bug? Intended behaviour is to leave blank with those.
Registered PI isn't indexed by model, so that can't be used automatically pulled.

@noble-ux noble-ux added enhancement An improvement to an already existing feature and removed bug Something's broken that shouldn't be. labels Aug 28, 2020
@noble-ux
Copy link
Member Author

We can move it around so
explicit PI ref (table or name) > default > inherit

Partial documentation issue, but ideally PI lighting would always be set to on when a model with a referenced PI is being used.

@noble-ux noble-ux changed the title PHOTON_INHERIT pulls an empty config Prioritize explicit PI ref over PHOTON_INHERIT Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an already existing feature
Projects
None yet
Development

No branches or pull requests

2 participants