Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pts/redis-1.4.0] NUM_CPU_PHYSICAL_CORES shall not be greater than 128 #292

Open
lucic71 opened this issue Oct 5, 2023 · 0 comments
Open

Comments

@lucic71
Copy link

lucic71 commented Oct 5, 2023

In pts/redis-1.4.0, if NUM_CPU_PHYSICAL_CORES is greater than 128, the following line from install.sh will fail:

echo \"io-threads \$NUM_CPU_PHYSICAL_CORES

See:
https://github.com/redis/redis/blob/2cf50ddbad1b8169ed31c913d6e6c860e4736f80/src/config.c#L3151

The solution is to just saturate NUM_CPU_PHYSICAL_CORES at 128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant