Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injected scripts work only on pages with cordova.js #161

Open
timkim opened this issue Jun 1, 2016 · 1 comment
Open

Injected scripts work only on pages with cordova.js #161

timkim opened this issue Jun 1, 2016 · 1 comment

Comments

@timkim
Copy link
Contributor

timkim commented Jun 1, 2016

This is an interesting issue that I just realised. Although it was made by design, I realised that people may want just plain vanilla .html pages but also want autoreload, console, etc to work when on that particular page.

So if a particular .html page does not have this string:

<script type=\"text/javascript\" src=\"cordova.js\"></script>

None of the scripts will inject!

Sources:
https://github.com/phonegap/connect-phonegap/blob/master/lib/middleware/zip.js#L74
https://github.com/phonegap/connect-phonegap/blob/master/lib/middleware/update.js#L61

This could also be the cause of many people's issues with autoreload. If they make a page and do not include the cordova.js script tag, then they get no updates from the server.

@amok
Copy link

amok commented May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants