Fixes for select #3127
Draft
Fixes for select #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any issues with this PR still in draft? |
is still on my todo list. so yes, the issue is that while this may fix the linked issues it may cause other problems. |
This commit adds a playground for testing select behaviors. It can be opened by starting the e2e server (npm run e2e:server) and then opening http://localhost:4004/select.
|
@chrismccord this is still on draft because I'm not sure about the changes. You can review it, I currently don't plan on adding more. For testing select behavior I added a select playground (npm run e2e:server -> http://localhost:4004/select). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3083.
Fixes #3107.
Could probably break something else. Draft only. More tests for select behavior should be added.