New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove phx-page-loading and phx-capture-click #1676
Comments
Hi @josevalim. May I ask why phx-capture-click is being removed? I've used phx-capture-click with a component on a modal to prevent the modal from receiving click events (and in my case submitting a form too early). What, if any, is the alternative to this. thanks. |
There is phx-click-away or something similar. |
Thanks for the quick reply but I'm struggling to see how As an example, I have a component which mimics a select dropdown. The below code is a skeleton example:
I can include this "select" component inside a form component that comes with Liveview 0.17.5. If I replace the cheers Dave |
Wouldn’t phx-click be enough for this case? |
No because For another example, standard forms are normally shown in a modal - without the |
I see. That’s something for Chris to consider then when going ahead with these deprecations! Thanks for clarifying! |
No problem. I've said it before but thanks for an awesome language and framework. |
|
Ah so my example was incorrect. I'll have another go at implementing my dropdown using the JS style of commands. Thanks for the help (and the amazing framework of course). |
HI Chris - I reimplemented my dropdown with just JS style commands and it works perfectly. |
I think those have been deprecated but the JavaScript code may still handle them. |
Is this something to consider removing for the 1.0.0 release if it is still in the code base? |
No description provided.
The text was updated successfully, but these errors were encountered: