Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter charts should not display a unit #49

Open
mcrumm opened this issue Apr 16, 2020 · 4 comments
Open

Counter charts should not display a unit #49

mcrumm opened this issue Apr 16, 2020 · 4 comments

Comments

@mcrumm
Copy link
Member

mcrumm commented Apr 16, 2020

The unit label on the y-axis and in the legend is confusing for a counter, since the values are simply positive whole numbers.

@leeoniya
Copy link

from #30 (comment) it sounds like you guys ditched donut charts for x/y plots? that's quite the change, considering how differently they show data. unless you're needing to show the counter progression over time, you might want to just DIY the donut charts via a sprinkle of SVG:

https://akzhy.com/blog/create-animated-donut-chart-using-svg-and-javascript/

uPlot is definitely not the hammer for every nail :P

although without seeing what you're referring to, i'm possibly inferring a lot of wrong stuff, heh.

@mcrumm
Copy link
Member Author

mcrumm commented Apr 16, 2020

Hi @leeoniya!

For more context, we're using uPlot to visualize data from Telemetry.Metrics. We're still in the very early stages of this implementation, so starting with a generic timeseries chart for all metrics types, given the performance improvements, seemed preferable for the time being.

That said, thank you very much for the link! ❤️ It's given me some new ideas :)

@josevalim
Copy link
Member

And for completeness, we should also ignore the value and keep a counter on the client.

@mcrumm
Copy link
Member Author

mcrumm commented Apr 26, 2020

we should also ignore the value and keep a counter on the client

That's how it's done now - counter increments by one for each event and sum increments by the y value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants