Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Countdown via notification or otherwise #14

Open
amanjitsk opened this issue Sep 1, 2020 · 1 comment · May be fixed by #23
Open

Countdown via notification or otherwise #14

amanjitsk opened this issue Sep 1, 2020 · 1 comment · May be fixed by #23
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@amanjitsk
Copy link

Hi,
Thanks for the great work. I was wondering if would be possible to emulate a countdown (either via libnotify or otherwise), that lets the user know the recording is about to start (in case of non-interactive launching - so no terminal output and with a delay). I think it would be a worthwhile feature to add. I realize I could hack around this with notifications but it would be great if it was built-in and calling the -y / --notify flag automatically takes care of it.
Best,
Amanjit
@phisch
Copy link
Owner

phisch commented Nov 19, 2020

Since i don't use notifications, i'm not interested in implementing this.
If someone wants to PR this, i'd look over it and merge it if it doesn't break anything though 🤷

@phisch phisch added enhancement New feature or request good first issue Good for newcomers labels Nov 19, 2020
@radiantly radiantly linked a pull request May 22, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support countdown via notification radiantly/giph
2 participants
@phisch @amanjitsk