Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with twilio-ruby 5.30.0 #7

Open
ajsharp opened this issue Dec 10, 2019 · 4 comments · May be fixed by #8
Open

Broken with twilio-ruby 5.30.0 #7

ajsharp opened this issue Dec 10, 2019 · 4 comments · May be fixed by #8

Comments

@ajsharp
Copy link

ajsharp commented Dec 10, 2019

twilio-ruby 5.30.0 does not define Twilio::TwiML::Response, which this library references below:

"self.output_buffer = ::Twilio::TwiML::Response.new do |twiml|;" +

I believe this is a relic of an old version of twilio-ruby library.

@philnash
Copy link
Owner

That is correct, you should check out version 2 for support for twilio-ruby version 5 and up.

@philnash
Copy link
Owner

You might find you need to update your TwiML to work with the later version of twilio-ruby, check out the release notes for a bit more detail.

@ajsharp
Copy link
Author

ajsharp commented Dec 10, 2019

I'm using twiml_template 2.0. Twilo::TwiML::Response doesn't exist in the twilio-ruby 5 and up.

@philnash
Copy link
Owner

Ah, apologies. You're right, that was just something that escaped my update.

I think this needs to be changed to

 "self.output_buffer = ::TwimlTemplate::Response.new do |twiml|;" + 

Could you try to change this and test in your app to see if it helps? I am travelling today, so can't test easily.

Let me know if that works and I can make the updates once I'm settled.

Thanks!

@whatnotery whatnotery linked a pull request Sep 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants