Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No style in the css for class="Grid-cell u-1of3" #92

Open
getsetbro opened this issue Aug 30, 2016 · 9 comments
Open

No style in the css for class="Grid-cell u-1of3" #92

getsetbro opened this issue Aug 30, 2016 · 9 comments

Comments

@getsetbro
Copy link

Thanks for your work on this!

The demo page shows you can set classes on a Grid-cell like: class="Grid-cell u-1of2"
But the css linked on the page has no classes for that: https://github.com/philipwalton/solved-by-flexbox/blob/master/assets/css/components/grid.css
There only a class for a .Grid-cell in a container of "Grid--1of3":

.Grid--1of3 > .Grid-cell {
  flex: 0 0 33.3333%;
}
@philipwalton
Copy link
Owner

The other CSS you're referencing can be found in the media.css ultility file. But I can see how this could be confusing. I'll look into adding extra links to these other files where it makes sense.

@getsetbro
Copy link
Author

Would those files be combined if I cloned and built the repo?

@philipwalton
Copy link
Owner

Building the repo produces the files that are on https://philipwalton.github.io/solved-by-flexbox/, so yes.

@dafriend
Copy link

dafriend commented Sep 4, 2016

In the interests of BEM methodology I suggest refactoring u-* to Util-* or Utility-*

@philipwalton
Copy link
Owner

Technically the methodology used on this site is SUIT CSS, which makes use of utility classes.

@rajasimon
Copy link

@philipwalton Also why <div class="Grid-cell Grid--1of3">...</div> is not working ?

@sanbor
Copy link

sanbor commented Nov 25, 2016

@rajasimon Probably because Grid--1of3 is a modifier of Grid, not a modifier of Grid-cell.

@pReya
Copy link

pReya commented Jun 14, 2017

I agree with @getsetbro. This confused me, too. I'd appreciate if you could include the full CSS in the examples on the page.

@gustiando
Copy link

Confusing indeed 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants