Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting additional WebView implementations. #2591

Open
lss4 opened this issue Nov 21, 2023 · 1 comment
Open

Supporting additional WebView implementations. #2591

lss4 opened this issue Nov 21, 2023 · 1 comment

Comments

@lss4
Copy link

lss4 commented Nov 21, 2023

Consider this a follow-up of #2239.

As Bromite hasn't been updated for a while I've migrated to Mulch which is still being maintained.

Similar to Bromite, an overlay is needed to allow Mulch WebView to be used. However, the previous overlay (/system/product/overlay/treble-overlay-highpriomisc.apk) introduced in v411 (which added Bromite) is taking precedence, preventing other overlays from taking effect.

I've inspected the GSI mentioned in my issue (which is maintained by ponces) and confirmed the presence of the overlay in question... so for now, in order to use Mulch WebView in GSIs, one either needs to remove/mask the treble-overlay-highpriomisc.apk overlay or merge the entry for Mulch into it.

@phhusson
Copy link
Owner

I see. That's rather annoying, because this overlays exists for a reason: some OEMs set their own value of webviews in a vendor overlay, hence we need to overwrite it with a high priority overlay.

I welcome any suggestion.
I'm perfectly fine with allowlisting (with signing public key) all major webviews (I personnaly use mulch webview in my personal builds already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants