Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push does not push tags other than in head commit #1812

Open
Ducasse opened this issue Mar 25, 2024 · 1 comment
Open

Push does not push tags other than in head commit #1812

Ducasse opened this issue Mar 25, 2024 · 1 comment
Labels

Comments

@Ducasse
Copy link
Collaborator

Ducasse commented Mar 25, 2024

  • create a tag
  • create a commit
  • push
  • the tag is not pushed

self tags is empty in the following method because it returns the tag of the commit which is a new commit.

IceGitLocalBranch>>pushTagsToRemote: aRemote gitRemote: gitRemote progress: pushProgress

	self tags do: [ :tag | 
		self 
			pushTag: tag 
			toRemote: aRemote 
			gitRemote: gitRemote 
			progress: pushProgress ]

Here is a possible fix

IceGitLocalBranch>>pushTagsToRemote: aRemote gitRemote: gitRemote progress: pushProgress

	self repository tags do: [ :tag | 
		self 
			pushTag: tag 
			toRemote: aRemote 
			gitRemote: gitRemote 
			progress: pushProgress ]
@tinchodias
Copy link
Collaborator

the possible fix makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants