Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixing iv and accessors is quite strange #1726

Open
Ducasse opened this issue Sep 4, 2023 · 2 comments
Open

mixing iv and accessors is quite strange #1726

Ducasse opened this issue Sep 4, 2023 · 2 comments

Comments

@Ducasse
Copy link
Collaborator

Ducasse commented Sep 4, 2023

retrieveDetail
	
	self mergeableMessage text: (self mergeableMessage text , '  Loading...' ).
	self schedule: [ 
		| detail mergeable |  
		[  
			detail := self pullRequest detail.
			mergeable := detail at: #mergeable ]
		on: Error do: [ :e | 
			mergeable := nil ].
		mergeableMessage defer: [
			mergeableMessage text: (self textForMergeable: mergeable) ].
		mergeableIcon defer: [
			mergeableIcon image: ( self iconForMergeable: mergeable) ] ]
@Ducasse
Copy link
Collaborator Author

Ducasse commented Sep 4, 2023

activate -> 1
alert: -> 1
chooseFrom:values:message:title: -> 3
confirm: -> 1
confirm:label: -> 1
confirm:label:trueChoice:falseChoice:cancelChoice:default: -> 5
deactivate -> 1
defer: -> 3
deny: -> 80
inform: -> 2
inform:actionOnClick: -> 1
informUser:during: -> 18
informUserDuring: -> 3
questionWithoutCancel:title: -> 1
request:initialAnswer:title: -> 1
  • defer: is ok

@Ducasse
Copy link
Collaborator Author

Ducasse commented Sep 4, 2023

esteban
is self window inform: good? as in

IceTipToFiletreeToTonelDialog >> accept

	"ensure window goes away (in case accept comes from a keybinding and not the ok button)"
	self closeWindow.
	selectedPackages ifEmpty: [ 
		self window inform: 'No packages selected.'.
		^ self ].
	(self model newAddPackagesAction: selectedPackages)
		executeWithContext: self

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant