New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopen FileDialog instead of assertion error #1709

Open

Ducasse opened this issue Jul 5, 2023 · 0 comments

Collaborator

Ducasse commented Jul 5, 2023 •

edited

Click on repair
Select locate ...
Pick any random folder that is not a git repo
You get the following AssertionFailure.
It would be better to reopen the filedialog or at least to show an error message with a button to reopen the filedialog.

IceTipRepairLocateRepository >> basicExecute
	| dialog |
	
	dialog := (IceTipLocalRepositoryPanel newApplication: context application)
		location: (self repository location ifNil: [ self defaultLocation ]);
		yourself.
	
		okAction: [ 
			dialog validate.
			self repositoryModel updateLocation: dialog location.
			true ];
		open

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment