Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup in BaselineOfEnlumineurFormatter and BaselineOfMicrodown #8016

Closed
astares opened this issue Dec 9, 2020 · 3 comments · Fixed by #16537
Closed

Small cleanup in BaselineOfEnlumineurFormatter and BaselineOfMicrodown #8016

astares opened this issue Dec 9, 2020 · 3 comments · Fixed by #16537

Comments

@astares
Copy link
Member

astares commented Dec 9, 2020

  • small cleanup in these two baseline packages: tag the uncategorized baseline packages with tag "Base"
    (as they have a manifest in that package which is tagged they are uncategorized)
@Ducasse
Copy link
Member

Ducasse commented Dec 10, 2020

No baselines for two classes should not have tag.

@astares
Copy link
Member Author

astares commented Dec 10, 2020

@Ducasse please do not be so quick in your decisions. You might think it is not worth to spend a tag here and therefore closed the issue. In my opinion too quickly.

PLEASE:
This is not dependent on the number of classes - we should stay consistent otherwise cleaning makes no sense at all.

To explain in detail: there is a manifest in these two packages which is always in Tag 'Manifest' (like in any other package) leaving the baseline class uncategorized. This fixes the uncategorized baseline classes it even when it might not be obvious in the first place.

image

Look at other places where we have this accepted and cleaned already - for instance "BaselineOfAthens" (similar issue, also with two tags only):

image

This cleanup also helps to prepare adding a Release test that no package has uncategorized classes. This is important not only to clean and get better quality but also to assure that quality level with tests afterwards.

So please try to understand my POV - we should provide a consistent image so people find their way easily and not being surprised that it is done differently all the time. This is how we should work: to act more professionally and give Pharo packages and the overall image a consistent feel. We should not decide case by case whatever we like most depending on mood or personal preference.

Please reopen the issue and check the PR again. Thanks in advance!

@astares
Copy link
Member Author

astares commented Dec 21, 2020

@Ducasse Are you able to check again my comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants