Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get info about the primitive table #747

Open
PalumboN opened this issue Feb 15, 2024 · 2 comments
Open

Get info about the primitive table #747

PalumboN opened this issue Feb 15, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@PalumboN
Copy link
Collaborator

PalumboN commented Feb 15, 2024

Sometimes some Pharo developers have doubts about the primitives (about the number, the name, and what it does).

Now I'm suggesting exploring the code of the initializePrimitiveTable method in the interpreter class.

Would be nice to have this information directly in the image, or at least in the wiki (I could not find it if it already exists). So they do not have to download the repo, install the code and blah blah to get the info.

This info could be generated from the initializePrimitiveTable method.
And we can add the comment in the primitive method (if it exists), for example:

primitiveExecuteMethodArgsArray
	"receiver, argsArray, then method are on top of stack.  Execute method against
	 receiver and args.  Allow for up to two extra arguments (e.g. for mirror primitives).
	 Set primitiveFunctionPointer because no cache lookup has been done for the
	 method, and hence primitiveFunctionPointer is stale."
@PalumboN PalumboN added the documentation Improvements or additions to documentation label Feb 15, 2024
@jordanmontt
Copy link
Member

jordanmontt commented Feb 15, 2024

+1

1 similar comment
@astares
Copy link
Member

astares commented Feb 15, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants