Bug in InterpreterPrimitives >> primitiveNotIdentical

[PalumboN]

The primitive is mixing receiver and argument when should following otherObject.

pharo-vm/smalltalksrc/VMMaker/InterpreterPrimitives.class.st

Lines 2889 to 2902 in de76067

	{ #category : #'object access primitives' }
	InterpreterPrimitives >> primitiveNotIdentical [
	"is the receiver/first argument not the same object as the (last) argument?.
	pop argumentCount because this can be used as a mirror primitive."
	| thisObject otherObject |
	otherObject := self stackValue: 1.
	thisObject := self stackTop.
	(objectMemory isOopForwarded: otherObject) ifTrue:
	[self assert: argumentCount > 1.
	otherObject := objectMemory followForwarded: thisObject].
	(objectMemory isOopForwarded: thisObject) ifTrue:
	[thisObject := objectMemory followForwarded: thisObject].
	self pop: argumentCount + 1 thenPushBool: thisObject ~= otherObject
	]

I don't know if the case never arrived because of:

• special selectors - always enter through the "inlined" bytecode -> In that case, is the primitive necessary?
• Never forwarded - Is the argument resolved before the call? -> In that case, is the check necessary in the definition?
• JIT compiler - the primitive is always jitted, so this function is invoked almost never.

[guillep]

good catch :)