Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax errors in mysources.list get ignored #671

Open
guillep opened this issue Feb 1, 2024 · 0 comments
Open

syntax errors in mysources.list get ignored #671

guillep opened this issue Feb 1, 2024 · 0 comments
Labels

Comments

@guillep
Copy link
Member

guillep commented Feb 1, 2024

Describe the bug
I have a mysources.list.
I had a syntax error (a comma missing between two templates that I copy pasted).
The launcher ignored it but did not report it.

Buggy:

OrderedCollection [
	PhLTemplateSource {
		#type : #HttpListing,
		#name : 'Pharo 12.0 posta',
		#url : 'https://files.pharo.org/image/90/',
                #filterPattern : 'href="(Pharo-?12(.0)?-SNAPSHOT.build.[^"]*.zip)"'
	}
	PhLTemplateSource {
		#type : #HttpListing,
		#name : 'Pharo 9.0 (stable)',
		#url : 'https://files.pharo.org/image/90/',
                #filterPattern : 'href="(Pharo-?9.0-SNAPSHOT.build.[^"]*.zip)"'
	}
]

Fixed:

OrderedCollection [
	PhLTemplateSource {
		#type : #HttpListing,
		#name : 'Pharo 12.0 posta',
		#url : 'https://files.pharo.org/image/90/',
                #filterPattern : 'href="(Pharo-?12(.0)?-SNAPSHOT.build.[^"]*.zip)"'
	},
	PhLTemplateSource {
		#type : #HttpListing,
		#name : 'Pharo 9.0 (stable)',
		#url : 'https://files.pharo.org/image/90/',
                #filterPattern : 'href="(Pharo-?9.0-SNAPSHOT.build.[^"]*.zip)"'
	}
]

Expected behavior
reporting the error to the user somehow

@guillep guillep added the Bug label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant