Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar displays "StringMorph" #669

Open
jecisc opened this issue Jan 30, 2024 · 8 comments
Open

Progress bar displays "StringMorph" #669

jecisc opened this issue Jan 30, 2024 · 8 comments
Labels

Comments

@jecisc
Copy link
Member

jecisc commented Jan 30, 2024

I took the development PharoLauncher and when I'm creating a new image (I took the P12 64bit development image) I get some "StringMorph" displayed in the progress bar:

image

Pharo Launcher version: 3.1.1-404-gef2c9dbc

@jecisc jecisc added the Bug label Jan 30, 2024
@Bajger
Copy link
Member

Bajger commented Jan 30, 2024

Relates to PR: #608
Probably due to migration from P10 to P11

@demarey
Copy link
Contributor

demarey commented Feb 1, 2024

This is strange. I cannot reproduce it even by taking the same version you reported: https://github.com/pharo-project/pharo-launcher/actions/runs/7584839224

GitHub
Lets you manage your pharo images and download new ones - Allow to define a short name on templates and create an image from th… · ef2c9db

@guillep
Copy link
Member

guillep commented Feb 1, 2024

I think we should wait until Pharo12 stabilises a bit here :)

@demarey
Copy link
Contributor

demarey commented Feb 1, 2024

yes, but PL uses P11, so it should work. The progress comes from PL and not the launched image.

@guillep
Copy link
Member

guillep commented Feb 1, 2024

@jecisc 's screenshot and his comments makes me think he got (somehow) a pharo launcher running on top of a latest P12 :)

@jecisc
Copy link
Member Author

jecisc commented Feb 1, 2024

The P12 image was the one that was been downloaded by the PL :)
But I took the PL provided at the meeting about the PL-CLI. That is in P11 IIRC

@guillep
Copy link
Member

guillep commented Feb 1, 2024

Well I confirm I saw the bug in Launcher 3.1.1-418-ge2eb5da2

@Bajger
Copy link
Member

Bajger commented Feb 1, 2024

Can we extend jobPresenterHeight? I think it could be because of different zoom ratio on OS: https://github.com/pharo-project/pharo-launcher/pull/608/files#diff-c99ee8b0d96b24723c910c09ac3b07cf39c7dd347af2b6c1eafa5f4481e26868R6

GitHub
fixes #595

There is unrelated commit on SpConfirmDialog, but I've included that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants