Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil doesn't work in Pharo11 in cases where FFI expects number #27

Open
Mr-Dispatch opened this issue Oct 17, 2023 · 2 comments
Open

Nil doesn't work in Pharo11 in cases where FFI expects number #27

Mr-Dispatch opened this issue Oct 17, 2023 · 2 comments

Comments

@Mr-Dispatch
Copy link

Hi, I had to patch 2 methods to use 0 instead of nil to be able to create/open DB.

ie. result := self getFileSize: stream lpFileSizeHigh: 0. in ODBWin32FileStream >> size.

I'll probably encounter some more places while trying OmniBase out.

Should I prepare a PR, eventually ?

@MarcusDenker
Copy link
Contributor

Take care: after we started looking at Omnibase, the original author informed us that it is not Open Source, it was ported years ago to Pharo but there was some miscommunication about the license.

(the source is available, but you need a per developer seat license somehow if you want to use it for real)

We should add a warning this repo and remove it at some point.

@Mr-Dispatch
Copy link
Author

I saw this on another repo (and kinda hoped that continued existence of this one with no mention meant the licensing issues "somehow resolved themselves"). Please, add the warning so no-one gets false hopes.

Well, not planning anything serious with it (just wanted to try what performance I might get out of "Pure Smalltalk Object DB").

Hopefully someday the "We'll build our own Pharo obj DB. With Blackack. And Hookers" I heard about a while back will pan out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants