Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support checking of inOrder for groups of calls rather than just individual calls. #189

Open
PSchwisow opened this issue May 22, 2015 · 3 comments
Milestone

Comments

@PSchwisow
Copy link

See https://github.com/PSchwisow/phergie-irc-plugin-react-altnick/blob/1.0.0/tests/PluginTest.php#L117-L131.

Each calls in the groups of three should happen before any of the calls in the subsequent group, but order within a group is an implementation detail. I would like to be able to wrap each of those groups in a structure that allows them to be unordered so that if this changes in the future the test will not break.

@mlively
Copy link
Collaborator

mlively commented May 22, 2015

Any recommendations on what this would look like in terms of phake calls?
If not no problem just curios if you have thoughts on that piece?
On May 21, 2015 6:08 PM, "Patrick Schwisow" notifications@github.com
wrote:

See
https://github.com/PSchwisow/phergie-irc-plugin-react-altnick/blob/1.0.0/tests/PluginTest.php#L117-L131
.

Each calls in the groups of three should happen before any of the calls in
the subsequent group, but order within a group is an implementation detail.
I would like to be able to wrap each of those groups in a structure that
allows them to be unordered so that if this changes in the future the test
will not break.


Reply to this email directly or view it on GitHub
#189.

@PSchwisow
Copy link
Author

I don't think there is currently a suitable wrapper in Phake, but I think something like Phake::anyOrder(...) with similar arguments as inOrder would work... both anyOrder and inOrder would need to support arguments that are calls to anyOrder, inOrder, or verify to allow flexibility in nesting.

@elazar
Copy link
Contributor

elazar commented Sep 21, 2015

Bump. I could use this feature at the moment, as I'm wanting to verify that a group of calls happens before other calls, but the ordering within the group itself isn't relevant.

@mlively mlively added this to the v2.2.0 milestone Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants