Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker and devcontainer build option #1050

Open
careless6666 opened this issue Apr 16, 2024 · 7 comments · Fixed by #1051
Open

Docker and devcontainer build option #1050

careless6666 opened this issue Apr 16, 2024 · 7 comments · Fixed by #1051

Comments

@careless6666
Copy link

Now there are instructions for building via installing libraries and via git. I tried both on mac m1 and ubuntu x86 and both crashed. It would be cool if there was a build option in Docker (via docker build ) this would increase the number of people who can fix something and contribute to it

My logs for ubuntu

git submodule update
Cloning into '/home/alex/Documents/github/pgbouncer/lib'...
Cloning into '/home/alex/Documents/github/pgbouncer/uthash'...
Submodule path 'lib': checked out '46a78d2616ba2e8b5855a3914d5e9375935cf61b'
Submodule path 'uthash': checked out 'eeba1961f203869116a865e57c968e9c86e1b8c4'

alex@alex-GS43VR-7RE:~/Documents/github/pgbouncer$ ./autogen.sh
Using aclocal: 1.16
configure.ac:15: warning: The macro `AC_PROG_CC_STDC' is obsolete.
configure.ac:15: You should run autoupdate.
./lib/autoconf/c.m4:1666: AC_PROG_CC_STDC is expanded from...
lib/m4/usual.m4:69: AC_USUAL_PROGRAM_CHECK is expanded from...
configure.ac:15: the top level

alex@alex-GS43VR-7RE:~/Documents/github/pgbouncer$ ./configure ...
configure: WARNING: you should use --build, --host, --target
checking build system type... Invalid configuration `...': machine `...-unknown' not recognized
configure: error: /bin/bash ./config.sub ... failed
@JelteF
Copy link
Member

JelteF commented Apr 16, 2024

alex@alex-GS43VR-7RE:~/Documents/github/pgbouncer$ ./configure ...
configure: WARNING: you should use --build, --host, --target
checking build system type... Invalid configuration `...': machine `...-unknown' not recognized
configure: error: /bin/bash ./config.sub ... failed

You seem to have snipped the import parts of the build error

@careless6666
Copy link
Author

I'm not sure I understood your answer
my full output where i follow readme instruction

 cd pgbouncer/

alex@alex-GS43VR-7RE:~/Documents/github/pgbouncer$ ls
AUTHORS     config.mak.in  COPYRIGHT             doc  include  Makefile  pyproject.toml  requirements.txt  test            uthash
autogen.sh  configure.ac   dev_requirements.txt  etc  lib      NEWS.md   README.md       src               uncrustify.cfg  win32

alex@alex-GS43VR-7RE:~/Documents/github/pgbouncer$ git submodule init
Submodule 'lib' (https://github.com/libusual/libusual.git) registered for path 'lib'
Submodule 'uthash' (https://github.com/troydhanson/uthash.git) registered for path 'uthash'

alex@alex-GS43VR-7RE:~/Documents/github/pgbouncer$ git submodule update
Cloning into '/home/alex/Documents/github/pgbouncer/lib'...
Cloning into '/home/alex/Documents/github/pgbouncer/uthash'...
Submodule path 'lib': checked out '46a78d2616ba2e8b5855a3914d5e9375935cf61b'
Submodule path 'uthash': checked out 'eeba1961f203869116a865e57c968e9c86e1b8c4'

alex@alex-GS43VR-7RE:~/Documents/github/pgbouncer$ ./autogen.sh
Using aclocal: 1.16
configure.ac:15: warning: The macro `AC_PROG_CC_STDC' is obsolete.
configure.ac:15: You should run autoupdate.
./lib/autoconf/c.m4:1666: AC_PROG_CC_STDC is expanded from...
lib/m4/usual.m4:69: AC_USUAL_PROGRAM_CHECK is expanded from...
configure.ac:15: the top level

alex@alex-GS43VR-7RE:~/Documents/github/pgbouncer$ ./configure ...
configure: WARNING: you should use --build, --host, --target
checking build system type... Invalid configuration `...': machine `...-unknown' not recognized
configure: error: /bin/bash ./config.sub ... failed

@JelteF
Copy link
Member

JelteF commented Apr 16, 2024

I mean you put all these ... there right? Or are they actually part of the output

@alvherre
Copy link

The ... are literally in the README.md file, and Alex seems to be pasting the lines exactly as the instructions say. The instructions do not say that you're supposed to replace these ... with the options you have determined to need. I suppose the title of this issue should be "instructions to build from source are unclear".

@Aleksandra973
Copy link

I totally agree, if we have dockerfile, we should execute only one command, and all configuration features will be under the hood and will be work the same in all os and machines

eulerto added a commit to eulerto/pgbouncer that referenced this issue Apr 17, 2024
The README uses ... in the configure command line to indicate that
options can be informed. However, it can confuse people (like in the
referred issue pgbouncer#1050). Removes the 3 dots and explains that configure
options can be informed.

Since I'm at it, informs that uthash submodule is also fetched if you
are following the Git instructions.

Fixes pgbouncer#1050
JelteF pushed a commit that referenced this issue Apr 17, 2024
The README uses ... in the configure command line to indicate that
options can be informed. However, it can confuse people (like in the
referred issue #1050). Removes the 3 dots and explains that configure
options can be informed.

Since I'm at it, informs that uthash submodule is also fetched if you
are following the Git instructions.

Fixes #1050
@JelteF
Copy link
Member

JelteF commented Apr 18, 2024

Re-opening this as I do think a Dockerfile in the repo would be nice. Especially if this includes a devcontainer: https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/introduction-to-dev-containers

@JelteF JelteF reopened this Apr 18, 2024
@JelteF JelteF changed the title Docker build option Docker and devcontainer build option Apr 18, 2024
@petere
Copy link
Member

petere commented Apr 18, 2024

Previous discussion about Docker: #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants