Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload vs online restart #1018

Open
Harif-Rahman opened this issue Feb 6, 2024 · 6 comments
Open

Reload vs online restart #1018

Harif-Rahman opened this issue Feb 6, 2024 · 6 comments
Labels
docs good-first-issue Good issue for new contributors to pick up

Comments

@Harif-Rahman
Copy link

Can someone explain the difference between RELOAD command and online restart using -R in command line.

Since we deprecated the online restart are we suggesting to go with RELOAD option?

@Harif-Rahman
Copy link
Author

Also i dont want to use so_reuseport option for now. in this case what is the recommendation to do hot reload without affecting existing connections?

@JelteF
Copy link
Member

JelteF commented Feb 6, 2024

Using the RELOAD command is generally what you want to use for hot reload. There are a few settings that you cannot change with a hot reload and which require a restart instead. But there are very few.

@Harif-Rahman
Copy link
Author

@JelteF
Can you give me the list of config parameter where the hot reload will not work ?

@JelteF
Copy link
Member

JelteF commented Feb 6, 2024

the ones with CF_NO_RELOAD in this list: https://github.com/pgbouncer/pgbouncer/blob/master/src/main.c#L234-L330

@JelteF JelteF added good-first-issue Good issue for new contributors to pick up docs labels Feb 6, 2024
@JelteF
Copy link
Member

JelteF commented Feb 6, 2024

It would be good to actually list in the documentation which config parameters require a restart (probably for some that's already done).

@Harif-Rahman
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs good-first-issue Good issue for new contributors to pick up
Projects
None yet
Development

No branches or pull requests

2 participants