Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling and logging #13

Open
petargyurov opened this issue Jan 20, 2021 · 1 comment
Open

Improved error handling and logging #13

petargyurov opened this issue Jan 20, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@petargyurov
Copy link
Owner

Feature
Currently not all errors are handled. We need a robust system that 1) notifies the user of any errors 2) logs detailed error information to a file

Additional Detail
Some errors are already handled, but there isn't much handling of errors coming from the backend process, especially during initiating of the child process.

@petargyurov petargyurov added the enhancement New feature or request label Jan 20, 2021
@petargyurov petargyurov self-assigned this Jan 20, 2021
@petargyurov petargyurov added this to To do in 0.0.1 Release Jan 20, 2021
@petargyurov petargyurov moved this from To do to In progress in 0.0.1 Release Jan 20, 2021
@petargyurov petargyurov moved this from In progress to Done in 0.0.1 Release Jan 21, 2021
@petargyurov
Copy link
Owner Author

The current implemenation is not as robust or as comprehensive as it should be but we have:

  • handling local JS errors
  • handling backend errors
  • handling stdout and stderr streams from the backend
  • logging everything to a log file

There is one (maybe two?) major unhandled cases:

  • remote code errors (i.e.: errors in libraries)
  • Electron errors in the main process
    • have not put in the time to implement this

I was really hoping that Electron would just have a global error handler that receives a callback but there doesn't seem to be such a feature. On top of that, not all JS errors trigger the typical error event handler... 😡

Bottom line is, there is still major room for improvement on this front. One thing that we need to seriously consider is the recycling of the log file. Right now it will grow in size until a new install (?) erases it.

@petargyurov petargyurov reopened this Jan 21, 2021
0.0.1 Release automation moved this from Done to In progress Jan 21, 2021
@petargyurov petargyurov moved this from In progress to To do in 0.0.1 Release Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

1 participant