Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear playlist takes too much time, let timeout be zero? #47

Open
elprup opened this issue Mar 20, 2016 · 1 comment
Open

clear playlist takes too much time, let timeout be zero? #47

elprup opened this issue Mar 20, 2016 · 1 comment

Comments

@elprup
Copy link

elprup commented Mar 20, 2016

First, thanks for your effort on this great library.
I notice when I try to remove all songs from playlist which including 40+ songs, it always takes a long time. In clearPlaylist I notice the function loop setTimeout is 100ms, which is too long for long list. I modify it to 0 and it works great.
I don't check the code related, is it the good practice? Why the initial timeout is 100ms?

@NevenLeung
Copy link

@elprup By using your question for reference, I change the timeout to 10ms and 5ms. It works fine, much quicker than 100ms. So far, it does not lead to any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants