Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory suggestion #41

Open
roybekhuis opened this issue Jan 22, 2016 · 0 comments
Open

Factory suggestion #41

roybekhuis opened this issue Jan 22, 2016 · 0 comments

Comments

@roybekhuis
Copy link

First of all thanks for all your effort in writing this angular wrapper!
There are two things that might be helpfull to implement in my opinion.
First change scope.$apply in the main directive to scope.$applyAsync as it gives Error: [$rootScope:inprog] $apply already in progress

I didn't see a play/pause function in the factory. As I understand you use initPlayTrack for that function.

I suggest to implement isResume to playTrack like this

ngSoundManager.factory( ...

        playTrack: function(trackId,isResume) {
            this.initPlayTrack(trackId,isResume);
        }

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant