Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make it work with python3.8 #173

Open
Haider8 opened this issue May 21, 2020 · 8 comments · Fixed by #174
Open

How to make it work with python3.8 #173

Haider8 opened this issue May 21, 2020 · 8 comments · Fixed by #174

Comments

@Haider8
Copy link
Contributor

Haider8 commented May 21, 2020

I am using python3.8.2 and it is continuously giving me syntax errors. How can I make it work with python3.8? I am using flake8.

@OrkoHunter
Copy link
Collaborator

Hey! I don't understand your question. PEP8Speaks (flake8 as linter) should work on any Python version.
PEP8Speaks does not have its own linter. Are there any unexpected errors which flake8 does not raise locally for you?

@Haider8
Copy link
Contributor Author

Haider8 commented May 22, 2020 via email

@OrkoHunter
Copy link
Collaborator

Oh interesting! Looks like I will have to update the flake8 and pycodestyle versions that I am using. May I ask you to create a PR? :)

@Haider8
Copy link
Contributor Author

Haider8 commented Jun 24, 2020

@OrkoHunter Hey, this issue still persists for me. Please take a look at this PR.

@OrkoHunter
Copy link
Collaborator

Huh, I see.

@OrkoHunter OrkoHunter reopened this Jun 25, 2020
@vhirtham
Copy link

vhirtham commented Jul 15, 2021

@OrkoHunter Hi, I get the already mentioned problem with the walrus operator in this PR

EDIT: I exchanged the affected lines in the PR because they got obsolete, but you can still see it in the edit history of the pep8speaks comment if that helps

@OrkoHunter
Copy link
Collaborator

@vhirtham I wonder if you use pycodestyle instead of flake8 as your linter, the issue goes away? We might need to update some versions of the linters, so that newer versions of Python are supported well.

@matteobachetti
Copy link

Same problem here: StingraySoftware/stingray#630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants