Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#143 leftovers and followups #146

Open
Villemoes opened this issue Mar 28, 2021 · 0 comments
Open

#143 leftovers and followups #146

Villemoes opened this issue Mar 28, 2021 · 0 comments

Comments

@Villemoes
Copy link

Some things off the top of my head that should/could be done at some point after #143 is merged, but which I'd rather not include in that already-way-too-long series.

  • check that no partition in the partition table lives before the GPT array (essentially redoing image-hd: enforce no GPT partition before the primary Partition Entry Array #125)
  • extend insert_image so it can be used as a full replacement for the few remaining uses of pad_file
  • perhaps add a check that when hd->gpt and image size is given that it's a multiple of 4K, to be consistent with the case where the image size is auto-computed to place the end of the gpt backup at a 4K boundary.
  • some code cleanups might be in order - I ended up introducing helpers like partition_end and min_ull/max_ull, and some existing code might benefit from using those.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant