Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise 6-position postcodes in addresses in the Netherlands (with spaces) #134

Open
emacgillavry opened this issue May 4, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@emacgillavry
Copy link
Contributor

emacgillavry commented May 4, 2021

Typically, addresses in the Netherlands have 4 digits, followed by 0 or 1 space, followed by 2 alphanumeric characters, e.g. "7512EC" or "7512 EC". The alphanumeric characters should not be "SA", "SD" or "SS":

/^[1-9][0-9]{3} ?(?!sa|sd|ss)[a-z]{2}$/i;

This bug is to track the latter case, i.e. "7512 EC".

@emacgillavry emacgillavry added the bug Something isn't working label May 4, 2021
emacgillavry added a commit to webmapper/parser that referenced this issue May 4, 2021
@emacgillavry
Copy link
Contributor Author

emacgillavry commented May 4, 2021

Regex works properly. However, it's further upstream the space in between breaks the postal code into 2 sections. Also happens for UK postcodes.

emacgillavry added a commit to webmapper/parser that referenced this issue Sep 7, 2021
Joxit pushed a commit that referenced this issue Sep 7, 2021
* Examples of correct addresses in NL.
* Recognise 6 position postcodes in NL, addressing #127.
* Check for -plein as street type.
* Adjustments for typo 'plain' instead of 'plein' in libpostal resources. Addressing #128.
* Put 'test' back in as per #126 (comment).
* Prevent 'St' as a suffix in NL streetnames. Add Jr and Sr. Addressing #126.
* First of 4 digits cannot be 0. No 'SA','SD' or 'SS'. Addressing #127.
* Adjective 'korte' no longer a personal title. Addressing #129.
* Tests and fix for typo 'BurgeRmeester'. Addressing #130.
* Tests, code, and configs for '-daal', '-burg', '-baan'. Addressing #131 and #133.
* Config for '-burg' not separable. Addressing #131.
* Remove test for NL postal codes WITH spaces. Regex ok. #134
* Fix formatting spaces at the end of the line.
* Also use directionals to parse Dutch street addresses. #137
* Add Dutch titulature for street name recognition. (#130)
* Add 'plantsoen' as a street type. (#128).
* Remove test for NL locality with stopword.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant