Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name in Pelias does not match name in Geonames #349

Open
missinglink opened this issue Feb 7, 2019 · 3 comments
Open

Name in Pelias does not match name in Geonames #349

missinglink opened this issue Feb 7, 2019 · 3 comments

Comments

@missinglink
Copy link
Member

Geonames record 2188922 is named Kelburn, but for some reason, it's named Northland in Pelias?

/v1/place?ids=geonames:neighbourhood:2188922

{
  "type": "Feature",
  "geometry": {
    "type": "Point",
    "coordinates": [
      174.76667,
      -41.28333
    ]
  },
  "properties": {
    "id": "2188922",
    "gid": "geonames:neighbourhood:2188922",
    "layer": "neighbourhood",
    "source": "geonames",
    "source_id": "2188922",
    "name": "Northland",
    "accuracy": "centroid",
    "country": "New Zealand",
    "country_gid": "whosonfirst:country:85633345",
    "country_a": "NZL",
    "region": "Wellington Region",
    "region_gid": "whosonfirst:region:85687233",
    "region_a": "WG",
    "county": "Wellington City",
    "county_gid": "whosonfirst:county:102079339",
    "county_a": "WE",
    "neighbourhood": "Northland",
    "neighbourhood_gid": "whosonfirst:neighbourhood:85773067",
    "continent": "Oceania",
    "continent_gid": "whosonfirst:continent:102191583",
    "label": "Northland, New Zealand"
  }
}
@missinglink
Copy link
Member Author

Interestingly, the name is correct when asking for a different language as per /v1/place?lang=ko&ids=geonames:neighbourhood:2188922

So I guess the error must lie with the translation code in API.

@missinglink
Copy link
Member Author

This doesn't seem to be in the changeLanguage middleware, because even if it was doing a placeholder query, there is no matching id in WOF:

placeholder://parser/findbyid?ids=2188922
{}

@orangejulius
Copy link
Member

Yeah this must be a super weird bug in the translation layer. I confirmed the record in Elasticsearch is called Kelburn:

curl -s localhost:9200/pelias/neighbourhood/2188922 | jq ._source.name
{
  "default": "Kelburn"
}

It's probably something Geonames specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants