Replies: 4 comments 5 replies
-
|
Any help? @pedroSG94 |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Hello, Did you tried to replace SurfaceView to OpenGlView everywhere in all classes? If you have a XML remember do it in the XML too |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
With surfaceView replaced with openGlView in every class, I get an error: Error from VSCode: |
Beta Was this translation helpful? Give feedback.
-
|
Hello, This error is not related with the library. You have a null pointer doing request permission. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
I fixed that error.. not sure where that came from wasn't having that issue before but I am back to where I was originally, with openGlView in place of surfaceView All I get is black screen. no camera preview nothing. |
Beta Was this translation helpful? Give feedback.
-
|
Can you share me the actual code with OpenGlView? |
Beta Was this translation helpful? Give feedback.
3 replies
-
|
Apologies mate, had a crazy few days at work.... I believe this is the code you are asking for: public class RTMPManager extends SimpleViewManager<OpenGlView> {
//TODO: "Do not place Android context classes in static fields (static reference to Publisher which has field _openGlView pointing to OpenGlView); this is a memory leak"
public static Publisher publisher;
public final String REACT_CLASS_NAME = "RTMPPublisher";
public OpenGlView openGlView;
private ThemedReactContext _reactContext;
View.OnLayoutChangeListener onLayoutChangeListener = new View.OnLayoutChangeListener() {
@Override
public void onLayoutChange(@NonNull View view, int i, int i1, int i2, int i3, int i4, int i5, int i6, int i7) {
}
};
@NonNull
@Override
public String getName() {
return REACT_CLASS_NAME;
}
@NonNull
@Override
protected OpenGlView createViewInstance(@NonNull ThemedReactContext reactContext) {
_reactContext = reactContext;
openGlView = new OpenGlView(_reactContext);
publisher = new Publisher(_reactContext, openGlView);
openGlView.addOnLayoutChangeListener(onLayoutChangeListener);
SurfaceHolderHelper surfaceHolderHelper = new SurfaceHolderHelper(_reactContext, publisher.getRtmpCamera(), openGlView.getId());
openGlView.getHolder().addCallback(surfaceHolderHelper);
return openGlView;
}
@ReactProp(name = "streamURL")
public void setStreamURL(OpenGlView openGlView, @Nullable String url) {
publisher.setStreamUrl(url);
}
@ReactProp(name = "streamName")
public void setStreamName(OpenGlView openGlView, @Nullable String name) {
publisher.setStreamName(name);
}
@Nullable
@Override
public Map<String, Object> getExportedCustomDirectEventTypeConstants() {
return MapBuilder.<String, Object>builder()
.put("onDisconnect", MapBuilder.of("registrationName", "onDisconnect"))
.put("onConnectionFailed", MapBuilder.of("registrationName", "onConnectionFailed"))
.put("onConnectionStarted", MapBuilder.of("registrationName", "onConnectionStarted"))
.put("onConnectionSuccess", MapBuilder.of("registrationName", "onConnectionSuccess"))
.put("onNewBitrateReceived", MapBuilder.of("registrationName", "onNewBitrateReceived"))
.put("onStreamStateChanged", MapBuilder.of("registrationName", "onStreamStateChanged"))
.put("onBluetoothDeviceStatusChanged", MapBuilder.of("registrationName", "onBluetoothDeviceStatusChanged"))
.build();
}
} |
Beta Was this translation helpful? Give feedback.
-
|
We can try inflate a layout instead of create an OpenGlView directly: public class RTMPManager extends SimpleViewManager<View> {
//TODO: "Do not place Android context classes in static fields (static reference to Publisher which has field _openGlView pointing to OpenGlView); this is a memory leak"
public static Publisher publisher;
public final String REACT_CLASS_NAME = "RTMPPublisher";
public OpenGlView openGlView;
private ThemedReactContext _reactContext;
@NonNull
@Override
public String getName() {
return REACT_CLASS_NAME;
}
@NonNull
@Override
protected View createViewInstance(@NonNull ThemedReactContext reactContext) {
_reactContext = reactContext;
LinearLayout layout = (LinearLayout) LayoutInflater.from(reactContext).inflate(R.layout.gl_container, null);
openGlView = layout.findViewById(R.id.surfaceView);
publisher = new Publisher(_reactContext, openGlView);
SurfaceHolderHelper surfaceHolderHelper = new SurfaceHolderHelper(_reactContext, publisher.getRtmpCamera(), openGlView.getId());
openGlView.getHolder().addCallback(surfaceHolderHelper);
return layout;
}
@ReactProp(name = "streamURL")
public void setStreamURL(OpenGlView openGlView, @Nullable String url) {
publisher.setStreamUrl(url);
}
@ReactProp(name = "streamName")
public void setStreamName(OpenGlView openGlView, @Nullable String name) {
publisher.setStreamName(name);
}
@Nullable
@Override
public Map<String, Object> getExportedCustomDirectEventTypeConstants() {
return MapBuilder.<String, Object>builder()
.put("onDisconnect", MapBuilder.of("registrationName", "onDisconnect"))
.put("onConnectionFailed", MapBuilder.of("registrationName", "onConnectionFailed"))
.put("onConnectionStarted", MapBuilder.of("registrationName", "onConnectionStarted"))
.put("onConnectionSuccess", MapBuilder.of("registrationName", "onConnectionSuccess"))
.put("onNewBitrateReceived", MapBuilder.of("registrationName", "onNewBitrateReceived"))
.put("onStreamStateChanged", MapBuilder.of("registrationName", "onStreamStateChanged"))
.put("onBluetoothDeviceStatusChanged", MapBuilder.of("registrationName", "onBluetoothDeviceStatusChanged"))
.build();
}
}where R.layout.gl_container is: <?xml version="1.0" encoding="utf-8"?>
<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_height="match_parent"
android:layout_width="match_parent"
>
<com.pedro.library.view.OpenGlView
android:layout_width="match_parent"
android:layout_height="match_parent"
android:id="@+id/surfaceView"
app:aspectRatioMode="adjust"
app:AAEnabled="false"
app:numFilters="1"
app:isFlipHorizontal="false"
app:isFlipVertical="false"
/>
</LinearLayout>Test it and show me logcat if you have a crash or the error persist. Also, share me current Publisher class |
Beta Was this translation helpful? Give feedback.
-
|
After that, try to replace this: SurfaceHolderHelper surfaceHolderHelper = new SurfaceHolderHelper(_reactContext, publisher.getRtmpCamera(), openGlView.getId());
openGlView.getHolder().addCallback(surfaceHolderHelper);To: openGlView.getHolder().addCallback(this);And just implement the interface in RTMPManager and make sure that callback is properly called |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
edit: I am fairly new to android studio / logcat so the logs still don't make perfect sense to me.
Hi, So previously I was using your project with another library to work with react-native And it was working fine with surfaceView, I want to switch to using OpenGlView so I can have a scoreboard Overlay on top of the RtmpCamera1 view So I can dynamically update text/scores during the stream as needed, I'm having trouble getting the OpenGlView to work... If you could help me at all in pointing me in the right direction it would be HUGE help and GREATLY appreciated...
This is my RTMPManager:
and this is my SurfaceHolderHelper:
And my RTMPPublisher:
basically in my RTMPManager I am trying to swap out SurfaceView for OpenGlView, with limited success I have tried dozens of ways of implementing the code for openGlView, either end up in a error asking to make sure openGlView has a Surface, or No errors but a black screen with logcat telling me this when i switch to the livestream view:
Any Ideas? =/
Beta Was this translation helpful? Give feedback.
All reactions