Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipsize #390

Open
WanekWest opened this issue Feb 3, 2023 · 0 comments
Open

Clipsize #390

WanekWest opened this issue Feb 3, 2023 · 0 comments

Comments

@WanekWest
Copy link

1)Are you sure that you need LateLoad check?

2)I think we dont need 65-76 liness. We are having sourcemod event: weapon_reload. It will provide little bit less server load.

3)I think we dont need to hook event and do anything with skill if config file wasnt found. Maybe we should do smth like this?
`
public void OnPluginStart()
{
LoadTranslations("smrpg_stock_upgrades.phrases");
g_bIsCSGO = GetEngineVersion() == Engine_CSGO;

if(LoadWeaponAmmoConfig())
{
	HookEvent("player_spawn", Event_OnPlayerSpawn);
	
	for(int i=1;i<=MaxClients;i++)
	{
		if(IsClientInGame(i))
			OnClientPutInServer(i);
	}
}

}
`

4)SDKHook(client, SDKHook_WeaponDropPost, Hook_OnWeaponDropPost); // I think we dont need it. If weapon were dropped - we forgot about it.

5)By the way we dont need to hook every client equip/drop. Maybe in 61 we should add Level checking? And after this we can use skill callback(Selling and buying) for hook/unhook additional players.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant