Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDS build 2018.3.23073.2 doesn't work with the latest released of ETP protocol 1.2 version. #45

Open
aramilointelie opened this issue Mar 27, 2023 · 0 comments

Comments

@aramilointelie
Copy link

Hi Team,

Currently the PDS ETP Browser doesn't work with the latest ETP release version 1.2.
The RequestSession message in protocol 0 is clearly from an old version.
Here is the JSON with the RequestSession message that was sent by PDS Studio.

{"protocol":0,"messageType":1,"correlationId":0,"messageId":1,"messageFlags":0}
{
  "applicationName": "PDS.WITSMLstudio.Desktop",
  "applicationVersion": "2018.3.23073.2",
  "requestedProtocols": [
    {
      "protocol": 3,
      "protocolVersion": {
        "major": 1,
        "minor": 2,
        "revision": 0,
        "patch": 0
      },
      "role": "store",
      "protocolCapabilities": {}
    }
  ],
  "supportedObjects": [],
  "supportedCompression": ""
}

After the latest release the RequestSession message has different fields some of them mandatory.
supportedObjects was changed to supportedDataObjects , supportedCompression now is an array of CharSequence instead of a single CharSequence.
Here is the new avro schema for this object as you will see there are many new fields.

{
      "type": "record",
      "namespace": "Energistics.Etp.v12.Protocol.Core",
      "name": "RequestSession",
      "protocol": "0",
      "messageType": "1",
      "senderRole": "client",
      "protocolRoles": "client, server",
      "multipartFlag": false,
      "fields": [
        {
          "name": "applicationName",
          "type": "string"
        },
        {
          "name": "applicationVersion",
          "type": "string"
        },
        {
          "name": "clientInstanceId",
          "type": "Energistics.Etp.v12.Datatypes.Uuid"
        },
        {
          "name": "requestedProtocols",
          "type": {
            "type": "array",
            "items": "Energistics.Etp.v12.Datatypes.SupportedProtocol"
          }
        },
        {
          "name": "supportedDataObjects",
          "type": {
            "type": "array",
            "items": "Energistics.Etp.v12.Datatypes.SupportedDataObject"
          }
        },
        {
          "name": "supportedCompression",
          "type": {
            "type": "array",
            "items": "string"
          },
          "default": []
        },
        {
          "name": "supportedFormats",
          "type": {
            "type": "array",
            "items": "string"
          },
          "default": [
            "xml"
          ]
        },
        {
          "name": "currentDateTime",
          "type": "long"
        },
        {
          "name": "earliestRetainedChangeTime",
          "type": "long"
        },
        {
          "name": "serverAuthorizationRequired",
          "type": "boolean",
          "default": false
        },
        {
          "name": "endpointCapabilities",
          "type": {
            "type": "map",
            "values": "Energistics.Etp.v12.Datatypes.DataValue"
          },
          "default": {}
        }
      ],
      "fullName": "Energistics.Etp.v12.Protocol.Core.RequestSession",
      "depends": [
        "Energistics.Etp.v12.Datatypes.Uuid",
        "Energistics.Etp.v12.Datatypes.SupportedProtocol",
        "Energistics.Etp.v12.Datatypes.SupportedDataObject",
        "Energistics.Etp.v12.Datatypes.DataValue"
      ]
    }

Have you been thinking about releasing a new version that works with the latest etp 1.2 version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant