Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions causing the session to terminate in class EtpSessionNativeClientBase not captured in log #14

Open
waveflight opened this issue Mar 1, 2022 · 0 comments

Comments

@waveflight
Copy link

Several exception handlers in this class have code to specifically exclude logging of details for exceptions where the connection is/will be terminated (as determined by the ExceptionMeansConnectionTerminated extension method). I not sure why the decision was made to exclude logging the details under such circumstances as this information can be useful.

Why this is of specific interest is because I previously run into a situation where the remote end was forcibly closing the connection after a period of time. The details of this were never actually captured in the log - because of the above mentioned check - making the problem that much harder to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant