Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert Behavior on scraping wallet without transactions #30

Open
XenonOrion opened this issue Jan 31, 2022 · 1 comment
Open

Assert Behavior on scraping wallet without transactions #30

XenonOrion opened this issue Jan 31, 2022 · 1 comment

Comments

@XenonOrion
Copy link

XenonOrion commented Jan 31, 2022

in commit fb697e1 the following behavior was introduced:

# etherscan/utils/parsing.py 
assert status, f"{result} -- {message}"

to replace the UserWarning behavior:

#etherscan/utils/parsing.py 
warnings.warn(f"{result} -- {message}")

This has made the event of scraping an empty address, "aggressive" and forces downstream applications to catch a generic AssertionError, for this---in my case common---scenario. imho, getting an empty list back in case no records exist, is completely valid behavior?

Could you elaborate on why this behavior was chosen, and this change was made?

@github-actions
Copy link

Thanks for reporting this issue, we are on it :)

@XenonOrion XenonOrion changed the title Assert Behavior on empty transactions Assert Behavior on scraping wallet without transactions Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant