Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable pay reminder for cashpayments? #6

Open
flashfingaz opened this issue May 11, 2018 · 5 comments
Open

disable pay reminder for cashpayments? #6

flashfingaz opened this issue May 11, 2018 · 5 comments

Comments

@flashfingaz
Copy link

although we have a note in the payment process, the reminder "please pay until ...." is quiet confusing for guests which want to pay at the event.

Is it possible to influence this via the plugin itself, so to remove the reminder for cashpayment? or is this too deep down in the pretix code?

@pc-coholic
Copy link
Owner

As far as I can see, this text is always printed, as it is part of the pretix-core and not configurable: https://github.com/pretix/pretix/blob/master/src/pretix/presale/templates/pretixpresale/event/order.html#L66

If you are only offering cash-payments, you might want to consider to set the deadline for payments so far out, that it reaches into the event. But I admit, that this is not a perfect solution...

I think we might have to look into providing a way to allow payment-providers to influence the expiration-date of an order.

@Pokerkoffer
Copy link

Reference code (important): XXXX-XXXXis printed as well and kinda confusing when paying cash :D

@felixrindt
Copy link

You can actually change order.expires, e.g. in execute_payment(...) to the day of the event, even when using subevents, which is another hurdle, but it's a hack :/

@pc-coholic
Copy link
Owner

Well, by using execute_payment(), we would be leveraging a regular endpoint - so while somewhat hacky, I wouldn't feel too doing it like that ;-)

I'll try to have a look at this soon(ish). But I reckon, we would probably need to also to provide a few additional settings...

  • Expiration as usual
  • Expiration at a set date
  • Expiration at start of event
  • Expiration at end of event
  • anything else?

@felixrindt
Copy link

Here's what I've added to my payment providers:

screenshot_20180816-165448__01

This could also be a PR for pretix-core (configurable expiration per payment provider), especially with the new manual payment provider.

I'd propose having the expiration a configurable number of days

  • Before the start of the event / the first subevent
  • Before the end of the event / end of the last sub event
  • After the start of the event / the first subevent
  • After the end of the event / end of the last subevent
  • After the order (as usual)
  • Set date (as usual)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants