[BUG] Windows - Opening settings is slow -> Some registry keys are read 72 times #3027
Labels
Comments
Caching is easy, cache invalidation isn't. By now, it would make sense if you would build QOwnNotes from source and run it in the debugger to see what's going on... |
|
Portable mode was just to replicate on my existing system without any of my stuff inherited. Can try this in portable mode too and see if it shows similar behavior, but then not against Windows registry. Alright. I've started reading up on it, but C++ and Qt is not my strong suite, quite new for me. I haven't even been able to set up a development environment. What is a good IDE to use on Windows? I've found "Another Qt Installer" and found an example install parameter that seems to work. Just have to get the correct Qt version, this was just an example:
|
|
QtCreator via https://www.qt.io/download-qt-installer-oss |
|
After many hours I've managed to build it, but the artifact won't run. 
The build instructions are not very clear for a C++ novice like myself.
If you get
I then tried using the build script used inside GitHub actions instead.
The steps I took to build on Windows: Click to viewInstall required tools
Install C++ build tools (gcc, g++ and make)# Open msys2
msys2
# Update repositories - Exit and reopen msys2 if asked
pacman --sync --refresh --sysupgrade
pacman --sync --sysupgrade
# Install make, GCC and G++
pacman --sync --needed base-devel make mingw-w64-x86_64-toolchain
# Exit from msys2
exitBuild from Windows Terminal using PowerShell v7.4.2# Assets
$BuildPath = [string] '{0}\Temp\Build' -f $env:LOCALAPPDATA
$RepoPath = [string] '{0}\QOwnNotes' -f $BuildPath
$QtPath = [string] '{0}\Qt' -f $BuildPath
$QtVersion = [string] '5.15.2'
# Initialize build dir
if ([System.IO.Directory]::Exists($BuildPath)) {
$null = [System.IO.Directory]::Delete($BuildPath,$true)
}
$null = [System.IO.Directory]::CreateDirectory($BuildPath)
# Clone QOwnNotes
Set-Location -Path $BuildPath
git clone --depth 1 --branch main https://github.com/pbek/QOwnNotes.git
Set-Location -Path $RepoPath
git submodule update --init
# Install Qt next to the repo directory for the build script to work
aqt install-qt windows desktop $QtVersion win64_mingw81 --outputdir $QtPath
# Add env variables to current process (does not persist)
[System.Environment]::SetEnvironmentVariable(
'PATH',
(
$env:Path,
('{0}\{1}\mingw81_64\bin' -f $QtPath, $QtVersion),
('{0}\scoop\apps\msys2\current\usr\bin' -f $env:USERPROFILE),
('{0}\scoop\apps\msys2\current\mingw64\bin' -f $env:USERPROFILE) -join ';' -replace ';{2,}', ';'
),
'Process'
)
# Make sure some of the known build tools are avaiable
'g++.exe','gcc.exe','make.exe','qmake.exe','windeployqt.exe' | ForEach-Object -Process {
Get-Command -Name $_
}
# Build using script
Set-Location -Path ('{0}\src' -f $RepoPath)
$ErrorActionPreference = 'Stop'
& '..\build-systems\github\windows\build-zip.ps1'Do you see any obvious flaws here? Edit: I seem to have hit the same problem as here: |
|
Oh, no. 😱 |
|
Doing release builds on Windows (or macOS) is a nightmare and took me a long time to chisel into shape on every platform I tried to do release builds (GitHub, AppVayor, ...). |
|
Learning by doing (it wrong 😁). I wanted to avoid having to register for Qt if possible. One can install Qt Creator with Scoop, which downloads and extracts a 7z archive from Qt, but it did not have much working out of the box. Not the Qt Maintenance tool either. I guess next step is to register with Qt and install Qt Creator using their installer. Using Dependencies ( https://github.com/lucasg/Dependencies ) it seems QOwnNotes.exe that I built on Windows 11 23H2 22631.x complains on not finding following DLLs:
Loading QOwnNotes.exe from relases ( https://github.com/pbek/QOwnNotes/releases/download/v24.5.4/QOwnNotes.zip ) does not show any missing DLLs. Kind of related issues: |
|
With a proper Qt Creator installation, then running QOwnNotes in debug mode (F5) with Qt 5.15.2 MinGW 32-bit. Opening settings gives following Application Output: With telemtry and heartbeat enabledWith heartbeat and telemtry disabledSo, both some TLS issues, and color space (sRGB)? I just realised I have no idea what I'm doing, or what I should do or look for. |
...the hard way. 😊
Yes, that's a pain in the neck. One more reason I don't like doing anything on Windows. 😁
Nice tool! |
|
I've no idea about the TLS issues. The libpng warning is a common issue you can't really get around, that's why I'm ignoring the warning in QOwnNotes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behaviour
Opening settings should only trigger reading a registry value once, unless it's already cached in the application?
Actual behaviour
Some registry keys, like "HKCU\Software\PBE\QOwnNotes\darkModeColors" are read 72 times.
Filtered on successfull events of this one registry key:
Steps to reproduce
en-us_windows_11_consumer_editions_version_23h2_updated_april_2024_x64_dvd_d986680b.iso@2xis covered in [BUG] Freezes and "Not responding" when reloading script engine on Windows #3024Output from the debug section in the settings dialog
Expand
QOwnNotes Debug Information
General Info
Current Date:
Fri May 10 11:36:38 2024Version:
24.5.1Build date:
May 5 2024Build number:
1097Platform:
windows (windows)Operating System:
Windows 10 Version 2009Build architecture:
x86_64Current architecture:
x86_64Release:
GitHub ActionsQt Version (build):
5.15.2Qt Version (runtime):
5.15.2Portable mode:
noSettings path / key:
\HKEY_CURRENT_USER\Software\PBE\QOwnNotesApplication database path:
C:\Users\localuser\AppData\Roaming\PBE\QOwnNotes\QOwnNotes.sqliteApplication arguments:
C:\Users\localuser\Desktop\QOwnNotes\QOwnNotes.exeQt Debug:
0Locale (system):
en_USLocale (interface): empty
Primary screen resolution:
1024x576Icon theme:
breeze-dark-qownnotesNotes in current note folder:
2Calendar items:
0Enabled scripts:
0Database drivers:
QSQLITE, QODBC, QODBC3, QPSQL, QPSQL7Server Info
serverUrl: empty
appIsValid:
yesnotesPathExists: empty
serverVersion: empty
appVersion: empty
Spellchecking
Enabled:
falseSelected language: empty
Language codes: empty
Language names: empty
Application dictionaries path:
C:\Users\localuser\AppData\Roaming\PBE\QOwnNotes\dictsNote folders
currentNoteFolderId:
1Note folder
defaultid:
1isCurrent:
yesactiveTagId:
0localPath:
C:\Users\localuser\NotesremotePath:
NotescloudConnectionId:
1isShowSubfolders:
noisUseGit:
noallowDifferentNoteFileName:
noactiveNoteSubFolder name: empty
database file:
C:\Users\localuser\Notes\notes.sqliteCloud connections
Cloud connection
Defaultid:
1isCurrent:
yesserverUrl: empty
username: empty
accountId: empty
Enabled scripts
Settings
ActiveNoteHistoryItem (NoteHistoryItem):
<binary data>Editor/CurrentSchemaKey (QString):
EditorColorSchema-cdbf28fc-1ddc-4d13-bb21-6a4043316a2fEditor/removeTrailingSpaces (QString):
falseLastUpdateCheck (QDateTime):
2024-05-10T11:36:32.927MainWindow/geometry (QByteArray):
<binary data>MainWindow/mainToolBar.iconSize (int):
24MainWindow/menuBarGeometry (QByteArray):
<binary data>MainWindow/noteTextEdit.code.font (QString):
Courier New,9,-1,2,50,0,0,0,0,0MainWindow/noteTextEdit.font (QString):
MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0MainWindow/noteTextView.code.font (QString):
Courier New,9,-1,2,50,0,0,0,0,0MainWindow/noteTextView.font (QString):
MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0NoteFolder-1/NoteTabNameList (QStringList):
Markdown CheatsheetNoteFolder-1/NoteTabStickinessList (QStringList): empty
NoteFolder-1/NoteTabSubFolderPathDataList (QStringList): empty
NoteHistory-1 (QVariantList):
<variant list with 2 item(s)>NoteHistoryCurrentIndex-1 (int):
1PiwikClientId (QString):
<hidden>SettingsDialog/geometry (QByteArray):
<binary data>SettingsDialog/mainSplitterState (QByteArray):
<binary data>WelcomeDialog/geometry (QByteArray):
<binary data>allowNoteEditing (QString):
trueallowOnlyOneAppInstance (QString):
trueappMetrics/notificationShown (QString):
truecheckSpelling (QString):
falsecryptoKey (qlonglong):
<hidden>currentNoteFolderId (int):
1currentWorkspace (QString):
initialdarkMode (QString):
truedarkModeColors (QString):
truedarkModeIconTheme (QString):
truedarkModeTrayIcon (QString):
truedemoNotesCreated (QString):
truedisableAutomaticUpdateDialog (QString):
truedockWasInitializedOnce (QString):
trueguiFirstRunInit (QString):
trueinitialLayoutIdentifier (QString):
minimalitemHeight (int):
15markdownHighlightingEnabled (QString):
truenoteEditIsCentralWidget (QString):
truenoteFileExtensionList (QStringList):
md, txtnotesPath (QString):
C:/Users/localuser/NotesownCloud/supportEnabled (QString):
falseownCloudInfo/appIsValid (QString):
trueownCloudInfo/connectionErrorMessage (QString): empty
ownCloudInfo/notesPathExistsText (QString): empty
ownCloudInfo/serverVersion (QString): empty
showMenuBar (QString):
trueshowStatusBar (QString):
truewebAppClientService/token (QString):
<hidden>workspace-initial/name (QString):
Minimalworkspace-initial/noteSubFolderDockWidgetVisible (QString):
trueworkspace-initial/windowState (QByteArray):
<binary data>workspaces (QStringList):
initialSystem environment
ALLUSERSPROFILE:
C:\ProgramDataAPPDATA:
C:\Users\localuser\AppData\RoamingCommonProgramFiles:
C:\Program Files\Common FilesCommonProgramFiles(x86):
C:\Program Files (x86)\Common FilesCommonProgramW6432:
C:\Program Files\Common FilesCOMPUTERNAME:
W1123H2ComSpec:
C:\Windows\system32\cmd.exeDriverData:
C:\Windows\System32\Drivers\DriverDataEFC_5264:
1FPS_BROWSER_APP_PROFILE_STRING:
Internet ExplorerFPS_BROWSER_USER_PROFILE_STRING:
DefaultHOMEDRIVE:
C:HOMEPATH:
\Users\localuserLOCALAPPDATA:
C:\Users\localuser\AppData\LocalLOGONSERVER:
\\W1123H2NUMBER_OF_PROCESSORS:
8OneDrive:
C:\Users\localuser\OneDriveOS:
Windows_NTPath:
C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Users\localuser\AppData\Local\Microsoft\WindowsApps;PATHEXT:
.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSCPROCESSOR_ARCHITECTURE:
AMD64PROCESSOR_IDENTIFIER:
Intel64 Family 6 Model 154 Stepping 3, GenuineIntelPROCESSOR_LEVEL:
6PROCESSOR_REVISION:
9a03ProgramData:
C:\ProgramDataProgramFiles:
C:\Program FilesProgramFiles(x86):
C:\Program Files (x86)ProgramW6432:
C:\Program FilesPSModulePath:
C:\Program Files\WindowsPowerShell\Modules;C:\Windows\system32\WindowsPowerShell\v1.0\ModulesPUBLIC:
C:\Users\PublicSESSIONNAME:
ConsoleSystemDrive:
C:SystemRoot:
C:\WindowsTEMP:
C:\Users\LOCALU~1\AppData\Local\TempTMP:
C:\Users\LOCALU~1\AppData\Local\TempUSERDOMAIN:
w1123h2USERDOMAIN_ROAMINGPROFILE:
w1123h2USERNAME:
localuserUSERPROFILE:
C:\Users\localuserwindir:
C:\WindowsRelevant log output in the Log panel
With all categories enabled.
Relevant resources
The text was updated successfully, but these errors were encountered: