Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Support startClass for Payara Micro in Gradle Plugin / FISH-6463 #52

Open
drame1499 opened this issue Aug 3, 2022 · 3 comments
Assignees
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Enhancement Label issue as an enhancement request

Comments

@drame1499
Copy link

Description


In the maven plugin it is possible to define a start class that is called to bootstrap payara micro.
The gradle plugin does currently not support this option.

Expected Outcome

Extend the gradle plugin to include the startClass attribute on the bundle task and generate an included jar and also update the MANIFEST.MF in generated uberJar just like the maven plugin does it

Current Outcome

Attribute startClass is not supported

Context

Ecosystem Tool

id "fish.payara.micro-gradle-plugin" version "1.1.0"

@drame1499 drame1499 added the Type: Enhancement Label issue as an enhancement request label Aug 3, 2022
@JamesHillyard JamesHillyard added the Status: Open Issue has been triaged by the front-line engineers and is being worked on verification label Aug 3, 2022
@JamesHillyard JamesHillyard self-assigned this Aug 3, 2022
@JamesHillyard
Copy link
Member

Hi @drame1499,

Just to clarify, could you please share the maven equivalent you are referring to which is missing in the gradle plugin?

Thanks,
James

@drame1499
Copy link
Author

Hi @JamesHillyard

I refer to the https://github.com/payara/ecosystem-maven/tree/master/payara-micro-maven-plugin and the

startClass (optional): Replaces Start-Class definition that resides in MANIFEST.MF file with the provided class.

option.
Best regards,
Philipp

@JamesHillyard
Copy link
Member

Hi @drame1499,

Thank you for clarifying that. I have raised this issue with the internal ID FISH-6463 to implement your enhancement request. We always encourage you to contribute, so if you wish you can submit a PR with implementing this feature, and we will gladly review it. Otherwise, we will pick up the issue at some point in the future.

Thanks,
James

@JamesHillyard JamesHillyard added Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Aug 3, 2022
@JamesHillyard JamesHillyard changed the title Enhancement: Support startClass fpr payara micro in gradle Plugin like already available in maven plugin Enhancement: Support startClass for Payara Micro in Gradle Plugin / FISH-6463 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Enhancement Label issue as an enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants