Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending functionality for JTACYearView and Delegates #1310

Open
robgtsoftware opened this issue Feb 24, 2021 · 2 comments
Open

Extending functionality for JTACYearView and Delegates #1310

robgtsoftware opened this issue Feb 24, 2021 · 2 comments

Comments

@robgtsoftware
Copy link

(Required) Version Number:
8.0.3

Description

It would be good to expand formal support for scrolling and selection within the JTACUYearView. For example these issues, #1226 and #1236 are currently outstanding and it would be good to have support for this basic interaction within the year view. Are you open to a PR to add this functionality? I have already done what I think will work to better support scrolling to a date in the year view and will start work on implementing a delegate method when selection occurs on a JTACMonthCell. Happy to discuss details and other items to add. I am needing this functionality for a current project I am working on, so happy to do the work.

Steps To Reproduce

N/A

Expected Behavior

Additional Context

N/A

@patchthecode
Copy link
Owner

Hey, because of lack of time these days, I appreciate any help I can get.
Especially if you already have a PR ready. Thanks so much.

robgtsoftware added a commit to robgtsoftware/JTAppleCalendar that referenced this issue Feb 26, 2021


Added support for scrolling year view to a specified date and a new delegate method to allow for detection of user selection of a given month view. Changed visibility of the extension to provide default protocol implementations so apps using library will benefit. Extended sample app to show new functionality in year view
@robgtsoftware
Copy link
Author

OK..have done. Sorry for the initial title, I was thinking I could do the two pull requests sequentially. Regardless, there is a PR for this issue and for another small issue. Happy to tweak and change as you like, but I think it is solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants