Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteroUses should populate loclist #124

Open
stellarhoof opened this issue Dec 8, 2017 · 3 comments
Open

InteroUses should populate loclist #124

stellarhoof opened this issue Dec 8, 2017 · 3 comments

Comments

@stellarhoof
Copy link

Right now, InteroUses behaves no differently than searching naively. If I wanted this, I'd search for the identifier myself. This adds a couple of problems:

  • Noise in the buffer (hlsearch is set by default)
  • False positives (even strings in comments are selected)
@owickstrom
Copy link
Collaborator

+1 on of this, but wouldn't it be better to populate quickfix, instead of loclist, as there might be usages in other files?

@stellarhoof
Copy link
Author

Better yet, provide an option for it. If it hardcodes one it might conflict with other plugins (e.x. linters). And so far from my testing, it only return usages for the current file. Maybe I'm missing something?

Ah also provide an option for customizing auto-open behavior :)

@parsonsmatt
Copy link
Owner

Yeah, my implementation for Uses is definitely a hack 😃 I'd be happy for a better implementation, but I'm not sure the best route forward there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants