Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionExtension: Update naming and support new transaction type. #1468

Open
jsdw opened this issue Mar 8, 2024 · 0 comments
Open

TransactionExtension: Update naming and support new transaction type. #1468

jsdw opened this issue Mar 8, 2024 · 0 comments

Comments

@jsdw
Copy link
Collaborator

jsdw commented Mar 8, 2024

See eg paritytech/polkadot-sdk#2280 and my comment here links to the bit showing the new encoding: paritytech/polkadot-sdk#2280 (comment) (though note that the actual extrinsic version will change to 5 for the new type based on latest comments).

Essentially right now we have:

  • Unsigned TX: (call_data)
  • Signed TX: (address, signature, extensions, call_data)

We'll add:

  • Unsigned TX with extensions: (extensions, call_data)

We are also renaming SignedExtensions to TransactionExtensions and changing the traits in Substrate a bit for how they work.

On the Subxt side we should do something along the lines of:

  1. Rename our SignedExtensions to TransactionExtensions (updating the other naming around these as appropriate, eg I think "additional signed" becomes "implicit").
    2 Rename our tx client methods to match the update, eg create_unsigned becomes create_bare.
  2. Introduce a new method, maybe on the offline side of the tx client which can construct such an extrinsic (maybe create_general).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant