Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util-crate: Create WebSocket and HTTP rpc client #1293

Open
lexnv opened this issue Nov 28, 2023 · 1 comment
Open

util-crate: Create WebSocket and HTTP rpc client #1293

lexnv opened this issue Nov 28, 2023 · 1 comment

Comments

@lexnv
Copy link
Contributor

lexnv commented Nov 28, 2023 •
edited

In a couple of places, namely CLI and lightClient builder, we duplicate the code for creating a WebSocket and HTTP RPC client.

Ideally, we could move the code to a dedicated util-crate and use that for both purposes.

Taken from: #1278 (comment)
@lexnv lexnv mentioned this issue Nov 28, 2023
Merged
@niklasad1
Copy link
Member

niklasad1 commented Nov 28, 2023 •
edited

My comment was essentially a util crate to establish a "WebSocket and HTTP RPC client" and not specifically fetching the chainSpec :)

@lexnv lexnv changed the title chainSpec: Create util-crate for fetching the chainSpec util-crate: Create WebSocket and HTTP rpc client Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niklasad1 @lexnv