Introduce sp_arithmetic as subxt::ext::sp_arithmetic and implement default substitues behind substrate-compat feature.
#1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeohepperle
force-pushed
the
tadeohepperle/pull-in-sp-arithmetic-for-perbill-permill-etc
branch
from
adfed21
to
e488a16
Compare
|
Needs some more thought because the types from sp_arithmetic do not implement EncodeAsType/DecodeAsType. Which results in invalid code being generated, when they are used as fields of generated structs that derive EncodeAsType. Closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1170
This PR adds
sp_arithmetic(16.0.0) as a dependency to subxt that is exposed unsersubxt::ext::sp_arithmetic.Currently I am facing the problem, that the types from
sp_arithmeticdo not implementEncodeAsTypeandDecodeAsTypeand we cannot easily implement them because of the orphan rule.Draft PR. Incomplete.