Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The backend reports duplicate peers. #497

Open
DamianStraszak opened this issue Sep 8, 2022 · 1 comment
Open

The backend reports duplicate peers. #497

DamianStraszak opened this issue Sep 8, 2022 · 1 comment

Comments

@DamianStraszak
Copy link

On https://telemetry.polkadot.io there are lots of duplicate entries shown, with the copies all being stuck on the same block 11857185 -- probably marks the moment when something bad happened to the backend.

The issue is present on all chains, not only polkadot. Attaching screenshot

Screenshot from 2022-09-08 12-12-37

@jsdw
Copy link
Collaborator

jsdw commented Oct 5, 2022

There is a small chance that this will be resolved by #504.

I did spend a bunch of time carefully digging through the code to see why this might be the case and nothing stands out at the moment. There is logic in place to handle various things being disconnected and restarted and it seems robust offhand. I believe we do have malicious connections/nodes and what you saw might have been an instance of it.

If it continues to be an issue after #504 I'll eventually dig more into it, but my best guess so far is malicious or broken nodes, since stale nodes and service disconnects all lead to fairly aggressive cleanups.

@jsdw jsdw removed the bug Something isn't working label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants