Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by genesis hash #263

Closed
bkchr opened this issue May 12, 2020 · 5 comments · Fixed by #335
Closed

Filter by genesis hash #263

bkchr opened this issue May 12, 2020 · 5 comments · Fixed by #335

Comments

@bkchr
Copy link
Member

bkchr commented May 12, 2020

The telemetry should filter by genesis hash for known networks like Kusama, Westend, Polkadot, etc.

We have restarted Westend quite some time ago, but some nodes still produce blocks on the old network. These nodes should not be visible on the Westend network tab. We could use the genesis hash to ensure that nodes are reporting indeed for the correct network.

@bkchr
Copy link
Member Author

bkchr commented Jun 9, 2020

@maciejhirsz can you please take care of this?

@maciejhirsz
Copy link
Contributor

@bkchr sorry, I was on holidays in-between this being submitted and now and didn't catch up. I'm looking into it now, and there is no genesis hash submitted by nodes to the telemetry. It should be trivial to add it to system.connected I reckon.

@bkchr
Copy link
Member Author

bkchr commented Feb 25, 2021

@maciejhirsz as we now send the genesis hash, could we now get this feature? :D

@maciejhirsz
Copy link
Contributor

@bkchr yeah, I'll put that into the refactoring of #310, should happen sometime in the next 2 weeks, pending on progress on jsonrpsee :)

@bkchr
Copy link
Member Author

bkchr commented Feb 25, 2021

Ty :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants