Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle substrate-connect/smoldot errors in Burnr wallet #840

Closed
wirednkod opened this issue Mar 4, 2022 · 2 comments
Closed

Handle substrate-connect/smoldot errors in Burnr wallet #840

wirednkod opened this issue Mar 4, 2022 · 2 comments
Labels
Burnr Wallet
Projects
V1 Launch
Milestone
Re-Release (v1)

Comments

@wirednkod
Copy link
Contributor

wirednkod commented Mar 4, 2022 •
edited

At the moment if substrate-connect/smoldot thorws an error, burnr wallet still shows the loader and there is no indication that an error occured.
This should be handled, and a relative error should be shown
@tomaka
Copy link
Contributor

tomaka commented Mar 5, 2022 •
edited

It's not "if smoldot crashes", but more generally:

  • If calling addChain/addWellKnownChain throws an exception.
  • Later, if an error event is generated in the ProviderInterface.

@wirednkod wirednkod changed the title Handle smoldot crashes in Burnr wallet Handle substrate-connect/smoldot errors in Burnr wallet Mar 6, 2022
@wirednkod wirednkod added this to the Re-Release (v1) milestone Jul 28, 2022
@wirednkod wirednkod added this to To do in V1 Launch via automation Sep 21, 2022
@wirednkod wirednkod mentioned this issue Mar 20, 2023
Open
2 tasks
@wirednkod
Copy link
Contributor Author

Closing here - added link into #1040

V1 Launch automation moved this from To do to Done Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Burnr Wallet
Projects
V1 Launch
Done
Milestone
Re-Release (v1)
Development

No branches or pull requests
2 participants
@tomaka @wirednkod